fix(token-search): fix token search results #3607
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| matched = t | ||
| // There should ever be only 1 token with a given address | ||
| // There can be multiple with the same symbol | ||
| matched.push(t) |
There was a problem hiding this comment.
Fix for missing entries.
Now all matches are collected.
| @@ -7,6 +7,6 @@ import { TokensMap } from '../types' | |||
| */ | |||
| export function tokenMapToListWithLogo(tokenMap: TokensMap): TokenWithLogo[] { | |||
| return Object.values(tokenMap) | |||
| .sort((a, b) => (a.symbol > b.symbol ? 1 : -1)) | |||
| .sort((a, b) => (a.symbol === b.symbol ? 0 : a.symbol > b.symbol ? 1 : -1)) | |||
There was a problem hiding this comment.
Fix for sorting.
We were not accounting for when symbols are identical.
There was a problem hiding this comment.
Actually, localeCompare is what we should use for strings.
There was a problem hiding this comment.
Wow! I didn't even know about it
| <h4>Favourite tokens</h4> | ||
| <InfoIcon iconType="help" content="Your favourite saved tokens. Edit this list in your account page." /> | ||
| <h4>Favorite tokens</h4> | ||
| <InfoIcon iconType="help" content="Your favorite saved tokens. Edit this list in your account page." /> |
There was a problem hiding this comment.
Additional request by Alex to update the spelling.
| @@ -7,6 +7,6 @@ import { TokensMap } from '../types' | |||
| */ | |||
| export function tokenMapToListWithLogo(tokenMap: TokensMap): TokenWithLogo[] { | |||
| return Object.values(tokenMap) | |||
| .sort((a, b) => (a.symbol > b.symbol ? 1 : -1)) | |||
| .sort((a, b) => (a.symbol === b.symbol ? 0 : a.symbol > b.symbol ? 1 : -1)) | |||
| @@ -7,6 +7,6 @@ import { TokensMap } from '../types' | |||
| */ | |||
| export function tokenMapToListWithLogo(tokenMap: TokensMap): TokenWithLogo[] { | |||
| return Object.values(tokenMap) | |||
| .sort((a, b) => (a.symbol > b.symbol ? 1 : -1)) | |||
| .sort((a, b) => a.symbol.localeCompare(b.symbol)) | |||
There was a problem hiding this comment.
funny, i just came to suggest this (use localeCompare), and I saw it was done moments ago!
There was a problem hiding this comment.
Got to it when reading https://levelup.gitconnected.com/cross-browser-crazy-44e90d61b204
alfetopito
force-pushed
the
fix/3599_token-search-results
branch
from
44768fa to
6e3a0a0
Compare
Summary
Fixes #3599
There were 2 issues with token search
Due to default browsers' sorting behaviour, the results were different when the symbols were identical.
This is the case for StaFi and Rocket Poll Eth.
In the displayed list of matches, we picked the one matching exactly the search terms, by address or symbol.
Turns out symbol is not unique, so we were silently dropping everything but the last match.
This is the case for both tokens above, as well as COW Protocol Token and cowfarm.finance
To Test
rethcow